Simplify build system #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake is unable to use multiple compilers within a single build. We require building multiple binaries, one for each model, and as such they often require different compilers for each. Therefore we feel it is simpler to provide a simple, sample Makefile for each model. Some common configurations will be specalised in due course.
Ruyk
reviewed
Feb 23, 2017
SYCL.make
Outdated
|
|
||
|
|
||
| SYCLStream.sycl: SYCLStream.cpp | ||
| compute++ SYCLStream.cpp -sycl -no-serial-memop -O2 -emit-llvm -c |
There was a problem hiding this comment.
If computecpp_info is on the path (as compute++ seems to be) you can just query it for the device compiler flags:
$ computecpp_info --dump-device-compiler-flags
-O2 -mllvm -inline-threshold=1000 -sycl -intelspirmetadata -emit-llvm
which you can use then for the makefile
(device compiler flags may change across versions)
There was a problem hiding this comment.
Thanks, we'll use this instead.
This doesn't include -no-serial-memop though (which leads to warnings from the compiler). Should we just ignore that?
jrprice
force-pushed
the
bugfix/build
branch
from
12506f1 to
d78baa4
Compare
Still needs additional work for HIP via HCC.
PGI creates these, even though we don't ask for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to simplify the build system in general for GPU-STREAM. CMake is unable to build multiple binaries using multiple compilers with a single evocation. As such, it is simpler to just provide simple Makefiles which build the binaries for the various models in common configurations. They are simple to extend and customise for specific platforms if required.
This should fix a number of the Issues, in particular #8, #9, #14 and #18.